Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2914: Display messages to show project file is loading #3073

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Aug 20, 2024

Description

This displays a message while a project file is loading. I'm not convinced this should be for 6.0.0, but it is a small change.

Fixes #2914

How Has This Been Tested?

Tested locally and from the push installer (Windows)

Review Checklist:

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Sorry, something went wrong.

@krzywon krzywon added Discuss At The Call Issues to be discussed at the fortnightly call SasView 6.0.0 Required for 6.0.0 release labels Aug 20, 2024
@krzywon krzywon linked an issue Aug 20, 2024 that may be closed by this pull request
@wpotrzebowski wpotrzebowski self-requested a review August 21, 2024 14:17
@wpotrzebowski
Copy link
Contributor

Tested on Mac and it works and looks as expected

Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Code looks OK.
A bit puzzled with \n - most messages emited don't have the carret return.
This will probably cause the status bar to change the height?

@krzywon
Copy link
Contributor Author

krzywon commented Aug 22, 2024

A bit puzzled with \n - most messages emited don't have the carret return. This will probably cause the status bar to change the height?

I just removed them

@rozyczko
Copy link
Member

carret return.

Did I say carret? lol. At least not carrot return...

@krzywon
Copy link
Contributor Author

krzywon commented Aug 22, 2024

carret return.

Did I say carret? lol. At least not carrot return...

🐰 🥕

@krzywon krzywon merged commit 7e34f96 into release_6.0.0 Aug 22, 2024
29 checks passed
@krzywon krzywon deleted the 2914-project-load-status branch August 22, 2024 14:30
@smk78 smk78 self-requested a review August 22, 2024 15:43
Copy link
Contributor

@smk78 smk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested actions build 10510126482 for functionality on W10/x86 with a dummy project using the infamous VMTA dataset.
Lovely! Puts a message in the status bar that says the project is loading, which changes to Project loaded when complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discuss At The Call Issues to be discussed at the fortnightly call SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not apparent anything is happening when opening a project
4 participants