Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3057: Change default settings #3074

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Aug 20, 2024

Description

This changes the default settings to show the mpl toolbar, and to not show polydispersity plots.

Fixes #3057

Review Checklist:

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@krzywon krzywon linked an issue Aug 20, 2024 that may be closed by this pull request
@wpotrzebowski wpotrzebowski added the SasView 6.0.0 Required for 6.0.0 release label Aug 21, 2024
@juliuskarliczek juliuskarliczek self-assigned this Aug 21, 2024
Copy link
Member

@juliuskarliczek juliuskarliczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, started sasview from the branch and the automatic show of polydispersity plots is disabled as well as the matplotlib toolbar is enabled.
Looked in the settings and the checkboxes are set correctly.
I will check the installers and write another comment

edit: the windows installer works with the changes but i do not have an osx machine to test the installer there.

@wpotrzebowski wpotrzebowski merged commit 2ebebcd into release_6.0.0 Aug 21, 2024
28 checks passed
@wpotrzebowski wpotrzebowski deleted the 3057-default-config-values branch August 21, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default settings should be changed/updated
3 participants