Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3016: Fix to PD changes #3084

Merged
merged 1 commit into from
Aug 22, 2024
Merged

3016: Fix to PD changes #3084

merged 1 commit into from
Aug 22, 2024

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Aug 21, 2024

Description

This takes the fix applied in #2991 a step further. The original fix did not account for the error column, and continued to modified the .width param regardless of the value changed.

Fixes #3016

How Has This Been Tested?

Tested locally - different function produce different shape distributions.

Review Checklist:

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and behaves as expected now.

I don't think it is new to this PR? But I noticed that the first change of polydisperse function on a given parameter triggers a run of the calculation but not for any future changes of function. I would think it is either a calculation whenever the function changes or never?

@wpotrzebowski wpotrzebowski added the SasView 6.0.0 Required for 6.0.0 release label Aug 22, 2024
@krzywon krzywon merged commit 3fc79b8 into release_6.0.0 Aug 22, 2024
28 checks passed
@krzywon krzywon deleted the 3016-pd-changes branch August 22, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing polydispersity function also forces the width of that dispersity to be very large.
3 participants