Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3086 weird plot auto scaling #3104

Merged
merged 2 commits into from
Sep 18, 2024
Merged

3086 weird plot auto scaling #3104

merged 2 commits into from
Sep 18, 2024

Conversation

lucas-wilkins
Copy link
Contributor

Description

Plot now picks range based on all plots, not just the last one

Fixes #3086

How Has This Been Tested?

Fit some data, look at the plots

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@lucas-wilkins lucas-wilkins marked this pull request as ready for review September 4, 2024 16:36
@wpotrzebowski wpotrzebowski added the SasView 6.0.0 Required for 6.0.0 release label Sep 4, 2024
@krzywon krzywon linked an issue Sep 6, 2024 that may be closed by this pull request
Weird plot auto scaling #3086
Closed
krzywon
krzywon approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and fixes the issue

@krzywon krzywon merged commit 5fab465 into release_6.0.0 Sep 18, 2024
34 checks passed
@krzywon krzywon deleted the 3086-weird-plot-auto-scaling branch September 18, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzywon krzywon krzywon approved these changes

@rozyczko rozyczko Awaiting requested review from rozyczko

Assignees
No one assigned
Labels
SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird plot auto scaling
3 participants
@lucas-wilkins @krzywon @wpotrzebowski