Purge generated files #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to track them in VCS.
No active settings. It gets overwritten by easy_install.
|
I remember wanting to do this earlier, but being told there is some reason the files were needed in the repo. I just looked through the tests, and the files are only used for writing, so it can't be something like them being needed for other tests (and even if it were, they should be generated anew each time). I'm applying the pull request, and if we are wrong we can always revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit tests would modify log and temporary files that are tracked in git. Remove and ignore them.
setup.py overwrites setup.cfg, which has no active settings. Remove and ignore it too.