Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Default to ./ when no <src> #351

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

valeriangalliat
Copy link
Member

So this is the simple version evoked here, where - is not a "special <src>", because it takes less code, and will be fine for 99.9% usages.
#350 needs to be merged first.

What's left
  • Make a default exclude pattern, for example taken from .gitignore, to not document sylesheets from vendor directories like node_modules.
  • Could also exclude destination directory, even if it's not supposed to contain documented Sass files.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.23% when pulling 9db90d6 on behavior-no-src-simple into 133057d on develop.

@pascalduez
Copy link
Member

It's so simple and clean it could be added to 2.0 ?

Which means no more cat file.scss | sassdoc - src/ ?
Which I totally fine with. I find it confusing.

@valeriangalliat
Copy link
Member Author

It's so simple and clean it could be added to 2.0 ?

Why not. @hugogiraudel?

Which means no more cat file.scss | sassdoc - src/ ?

Yep.

Which I totally fine with. I find it confusing.

Alright, it's really an edge case to me anyway.

@KittyGiraudel
Copy link
Member

Eveyrthing fine with me folks.

@valeriangalliat
Copy link
Member Author

Well while I think of it there's still issues about using ./, by default or not; if there's a node_modules or any kind of vendor directory, all Sass files in it will be documented too, and it's not what we want. We would need some kind of default exclude, from .gitignore for example.

Let's not merge this incomplete feature for 2.0. There's still stuff to be done with default exclude patterns.

@valeriangalliat valeriangalliat changed the title Default to ./ when no <src> [WIP] Default to ./ when no <src> Jan 30, 2015
@valeriangalliat valeriangalliat added this to the 2.2 milestone Jan 30, 2015
@valeriangalliat valeriangalliat self-assigned this Jan 30, 2015
@KittyGiraudel
Copy link
Member

Okay. We'll see in 3.0 if it still makes sense.

@valeriangalliat valeriangalliat modified the milestones: 3.0, 2.2 Jan 30, 2015
@valeriangalliat valeriangalliat removed their assignment Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants