Adjusts pre-commit to work on Windows
#2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhammondmusic
changed the title
pre-commit to work on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
For Windows, it worked when i specified the
bashcommand rather than just using./to invoke the sh scriptfixes #2954
Has this been tested? How?
working on my Windows VM and on my Mac. I did also add some entries to the PATH environmental variables on windows, not sure if that was needed to get this to work
Screenshots (if appropriate)
Types of changes
(leave all that apply)
New frontend preview link is below in the Netlify comment 😎