-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Window size setting #1299
Conversation
UI Automated Tests execution is complete! You can find the test results report here |
While testing I noticed a bug on MacOS, I was not able to replicate on Windows or Linux. When you re open the app on MacOS the width will be the same as when you closed app but the height will stretch from the top of the screen to the bottom Screen.Recording.2023-10-10.at.12.00.22.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, resizing the window emits a large number of events. Saving state every time will hit disk a lot. oh well - don't really have a better way to do it at the moment.
ye unless there is a way to detect when someone stops resizing (which i doubt) i dont think there is a better way. |
missing linter 🔨 |
should we also save the window position? as the position will be default value so depending on app size the window can still go out of the screen |
Would this be hard to do? It might be nice to add but if it might come with a lot of bugs and be a lot of hard work it might be best to hold that off for a later time |
@phillsatellite @Flemmli97 |
done. might not work on linux though as the api handling the position does not work right there |
What this PR does 📖
Which issue(s) this PR fixes 🔨