-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(markdown): use new markdown crate #1336
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto fix/markdown-again
…nto fix/markdown-again
github-actions
bot
added
Don't merge yet
DO NOT MERGE
Missing dev review
Still needs to be reviewed by a dev
labels
Oct 16, 2023
phillsatellite
added
Changes requested
When other dev or QA request a change
and removed
Ready for testing
Ready for QA to test
labels
Oct 17, 2023
@phillsatellite underline isn't supported. |
Looks like the existing markdown to send code in a message is not working with this PR and thats why the chats tests are failing |
sdwoodbury
force-pushed
the
fix/markdown-again
branch
from
October 18, 2023 15:37
f17ffd7
to
15b2bfb
Compare
I found that code blocks don't display html tags - probably because messages are displayed using |
github-actions
bot
removed
Changes requested
When other dev or QA request a change
Missing dev review
Still needs to be reviewed by a dev
Don't merge yet
DO NOT MERGE
Failed Automated Test
This PR is failing Luis's Appium test and needs revised
linter failing
Cargo Workflow (linter) failed on this PR
labels
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
markdowns
crate, produced by Satellite.im.Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤