Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat): Scroll to time ago element #1350

Merged
merged 3 commits into from
Oct 19, 2023
Merged

fix(chat): Scroll to time ago element #1350

merged 3 commits into from
Oct 19, 2023

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Fixes chat to bottom scroll not including the timestamp element

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Oct 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

460 tests   404 ✔️  1h 47m 19s ⏱️
  39 suites    56 💤
    3 files        0 ❌

Results for commit e91db54.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

stavares843
stavares843 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 🎉

@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Oct 19, 2023
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Oct 19, 2023
@sdwoodbury sdwoodbury merged commit 1c68c1e into dev Oct 19, 2023
7 of 8 checks passed
@sdwoodbury sdwoodbury deleted the message_scroll_fix branch October 19, 2023 13:52
@github-actions github-actions bot removed QA Tested QA has tested and approved Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

@sdwoodbury sdwoodbury sdwoodbury approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(chat): User needs to scroll down to see timestamp
4 participants
@Flemmli97 @sdwoodbury @stavares843 @phillsatellite