fix(quickprofile): Disable onblur for msg and hide profile on enter #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flemmli97
changed the title
|
|
github-actions
bot
added
Don't merge yet
|
So during testing I had some weird behavior In a group chat I opened up Windows quickprofile and tried to send a message. When I sent the message instead of it sending just to the Windows profile in a DM it would try to send in the group And it seems like the message would never fully send it would appear with 50% opacity and no other users would receive Screen.Recording.2023-10-27.at.12.22.37.PM.mov |
|
UI Automated Tests execution is complete! You can find the test results report here |
github-actions
bot
removed
the
Failed Automated Test
|
Noticed this crash on Linux and MacOS flow was: Screen.Recording.2023-10-31.at.2.38.52.PM.mov |
sdwoodbury
approved these changes
Oct 31, 2023
|
@phillsatellite can you attach the crash report? |
github-actions
bot
added
Failed Automated Test
|
WalkthroughWalkthroughThe changes primarily focus on refactoring the Changes
Assessment against linked issues (Beta)
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- common/src/state/mod.rs (1 hunks)
- ui/src/layouts/chats/presentation/quick_profile/mod.rs (1 hunks)
Additional comments: 3
common/src/state/mod.rs (2)
1173-1176: The check for the active chat ID has been removed. This change could potentially affect other parts of the code that rely on this function. Ensure that all calls to this function throughout the codebase have been updated to match the new behavior.
1185-1187: The function now directly uses the provided
idparameter to retrieve the chat and increment the outgoing messages for the specified chat. This change streamlines the process of appending the provided message and attachments to the outgoing messages for a specific chat.ui/src/layouts/chats/presentation/quick_profile/mod.rs (1)
- 400-413: The
onreturnevent handler has been updated to hide the context menu after a message is sent. This is done by adding a class "hidden" to the context menu element. This is a good practice as it improves the user experience by automatically closing the context menu after the user has finished interacting with it. However, it's important to ensure that the class "hidden" is properly defined in your CSS and actually hides the element. Also, thedisable_onblurattribute has been added to theInputcomponent and set totrue. This prevents the quickprofile from disappearing when the user clicks outside the input box, which can be a useful feature in some cases. However, it's important to consider the potential impact on the user experience. If the quickprofile is not expected to disappear when the user clicks outside of it, this could lead to confusion or frustration. Therefore, it's recommended to clearly communicate this behavior to the user, for example through a tooltip or other form of user guidance.
|
did you have the extension up to date? |
github-actions
bot
added
the
Failed Automated Test
github-actions
bot
removed
the
Failed Automated Test
|
I should've and on MacOS14 but I can re test to verify |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- common/src/state/mod.rs (1 hunks)
Additional comments: 3
common/src/state/mod.rs (3)
1197-1200: The
send_messagefunction has been refactored to delegate the message appending process to theincrement_outgoing_messages_forfunction. This is a good practice as it improves the modularity and readability of the code.1203-1213: The new function
increment_outgoing_messages_foris introduced. It takesmsg,attachments, andidas input parameters and handles the logic previously present in thesend_messagefunction. The retrieval of thedidvariable is now done within this function. This is a good practice as it improves the separation of concerns in the code.1211-1211: Ensure that the
append_pending_msgfunction handles the case where theiddoes not exist inself.chats.all. If it doesn't, it could lead to a runtime error.
phillsatellite
removed
the
Changes requested
phillsatellite
approved these changes
Nov 7, 2023
phillsatellite
added
the
Waiting for CI
github-actions
bot
added
the
Failed Automated Test
phillsatellite
removed
the
Failed Automated Test
phillsatellite
added
QA Tested
github-actions
bot
removed
QA Tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Which issue(s) this PR fixes 🔨