Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): Remove a logging message that was left in #1447

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Remove a logging message in a script that was accidentally left in

Copy link

coderabbitai bot commented Nov 3, 2023

Walkthrough

Walkthrough

The change made is minor and involves the removal of a debugging statement from the JavaScript file. This statement was a console.log command used for debugging purposes. Its removal does not impact the functionality of the code but makes it cleaner and more production-ready.

Changes

File Path Summary
.../textarea/update_char_counter.js Removed a console.log statement used for debugging. This change does not affect the code's functionality.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Nov 3, 2023
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 2e6b28a and 63ad4d1.
Files selected for processing (1)
  • kit/src/elements/textarea/update_char_counter.js (1 hunks)
Files skipped from review due to trivial changes (1)
  • kit/src/elements/textarea/update_char_counter.js

@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Nov 3, 2023
Copy link
Contributor

github-actions bot commented Nov 3, 2023

UI Automated Test Results Summary for MacOS/Windows

476 tests   266 ✔️  1h 23m 14s ⏱️
  41 suites  210 💤
    3 files        0

Results for commit 63ad4d1.

Copy link
Contributor

github-actions bot commented Nov 3, 2023

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Nov 3, 2023
@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Nov 3, 2023
@stavares843 stavares843 merged commit f98ef42 into dev Nov 3, 2023
13 checks passed
@stavares843 stavares843 deleted the remove_log_script branch November 3, 2023 17:58
@github-actions github-actions bot removed QA Tested QA has tested and approved Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants