-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(misc): return error via oneshot to prevent panicking #1449
Conversation
WalkthroughWalkthroughThe modification in the codebase primarily focuses on enhancing error handling during the initialization of Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- common/src/warp_runner/mod.rs (1 hunks)
Additional comments: 1
common/src/warp_runner/mod.rs (1)
- 174-179: The error handling here is good. It logs the error, sends the error back to the caller, and then returns from the function. This is a good practice as it allows the caller to decide what to do with the error.
UI Automated Tests execution is complete! You can find the test results report here |
What this PR does π
Which issue(s) this PR fixes π¨
Special notes for reviewers ποΈ
Additional comments π€