Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Change button tooltip layout #1450

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Changes style of some button tooltips (right sided arrow type). Makes it more consistent in its position

Which issue(s) this PR fixes 🔨

Copy link

coderabbitai bot commented Nov 3, 2023

Walkthrough
Assessment against linked issues (Beta)
Objective Addressed Explanation
Improve user interface in the 'files' section The changes in kit/src/elements/tooltip/style.scss and ui/src/layouts/chats/style.scss are related to the user interface and specifically the tooltip arrow positioning. The addition of the new CSS class and the removal of the existing CSS rule indicate an intentional effort to enhance the user interface.
Add padding to 'upload files' hover state There is no mention of adding padding to the 'upload files' hover state in the provided changes. The changes are focused on tooltip arrow positioning and do not address the reported issue.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Nov 3, 2023
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 2e6b28a and e5e3fb4.
Files selected for processing (3)
  • kit/src/elements/tooltip/style.scss (1 hunks)
  • ui/src/layouts/chats/style.scss (1 hunks)
  • ui/src/layouts/storage/files_layout/mod.rs (1 hunks)
Files skipped from review due to trivial changes (2)
  • kit/src/elements/tooltip/style.scss
  • ui/src/layouts/chats/style.scss
Additional comments: 1
ui/src/layouts/storage/files_layout/mod.rs (1)
  • 177-183: The change in arrow position from Top to TopRight should be verified in the UI to ensure it aligns with the overall design and doesn't obstruct any other UI elements.
- arrow_position: ArrowPosition::Top,
+ arrow_position: ArrowPosition::TopRight,

@phillsatellite phillsatellite added the Waiting for CI Waiting for at least one CI job to complete before merging label Nov 3, 2023
Copy link
Contributor

github-actions bot commented Nov 3, 2023

UI Automated Test Results Summary for MacOS/Windows

476 tests   266 ✔️  2h 11m 10s ⏱️
  41 suites  210 💤
    3 files        0

Results for commit 868267c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 3, 2023

UI Automated Tests execution is complete! You can find the test results report here

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between e5e3fb4 and 868267c.
Files selected for processing (1)
  • ui/src/layouts/chats/style.scss (1 hunks)
Files skipped from review due to trivial changes (1)
  • ui/src/layouts/chats/style.scss

@phillsatellite phillsatellite added QA Tested QA has tested and approved Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE Waiting for CI Waiting for at least one CI job to complete before merging labels Nov 6, 2023
@stavares843 stavares843 merged commit bc981f6 into dev Nov 6, 2023
11 checks passed
@stavares843 stavares843 deleted the btn_tooltip_padding_fix branch November 6, 2023 16:30
@github-actions github-actions bot removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improvement(files): lacking padding on toast
5 participants