Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): Profile picture/banner split #1775

Merged
merged 29 commits into from
Feb 7, 2024
Merged

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Makes it so profile pictures and banner queries are fetched and updated off thread. For each query a thread will be spawned that fetches the data from warp (also batchable). Afterwards a message will be send across a channel from which uplink will handle the data.

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Jan 29, 2024
@github-actions github-actions bot added the linter failing Cargo Workflow (linter) failed on this PR label Jan 29, 2024
@github-actions github-actions bot removed the linter failing Cargo Workflow (linter) failed on this PR label Jan 29, 2024
Copy link
Contributor

github-actions bot commented Jan 29, 2024

UI Automated Test Results Summary for MacOS/Windows

502 tests   450 ✅  2h 14m 11s ⏱️
 42 suites   52 💤
  3 files      0 ❌

Results for commit 94be621.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 29, 2024

UI Automated Tests execution is complete! You can find the test results report here

@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Jan 29, 2024
common/src/profile_update_channel.rs Outdated Show resolved Hide resolved
common/src/profile_update_channel.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Jan 30, 2024
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Jan 31, 2024
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Jan 31, 2024
@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Jan 31, 2024
@dariusc93
Copy link
Contributor

fixed but also wondering: it will wait for the data from warp before updating the profile pic. do we maybe want to have it so it updates immediately? (though in this case if e.g. an error comes from warp the pic will be reset again which can cause confusion)

If im understanding this statement, then for your own profile, you shouldnt need to concurrently fetch your own identity after updating your profile since the purpose of this is to improve the initial load time by offloading the loading of images into a separate task and update the state with that data if its available. If you are to stick with using this while updating your profile then you might have to wait a bit because it might be that the state is being updated out of order

@stavares843
Copy link
Member

the avatar is showing now but still appears the error in the log

Captura de ecrã 2024-02-05, às 19 50 34

@stavares843 stavares843 added Changes requested When other dev or QA request a change and removed checking stuff labels Feb 5, 2024
@Flemmli97 Flemmli97 removed the Changes requested When other dev or QA request a change label Feb 6, 2024
@stavares843 stavares843 added the Missing dev review Still needs to be reviewed by a dev label Feb 6, 2024
@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Feb 6, 2024
common/src/profile_update_channel.rs Outdated Show resolved Hide resolved
common/src/profile_update_channel.rs Outdated Show resolved Hide resolved
@dariusc93 dariusc93 added Waiting for CI Waiting for at least one CI job to complete before merging Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Waiting for CI Waiting for at least one CI job to complete before merging labels Feb 7, 2024
@stavares843 stavares843 added Waiting for CI Waiting for at least one CI job to complete before merging and removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Feb 7, 2024
@stavares843 stavares843 merged commit 0e5f783 into dev Feb 7, 2024
5 checks passed
@stavares843 stavares843 deleted the profile_pic_banner_split branch February 7, 2024 18:27
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed Waiting for CI Waiting for at least one CI job to complete before merging labels Feb 7, 2024
@stavares843 stavares843 removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(misc): Load identity images separately
5 participants