Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(flags): use flags as images with wix updates #1817

Merged
merged 5 commits into from
Feb 2, 2024
Merged

update(flags): use flags as images with wix updates #1817

merged 5 commits into from
Feb 2, 2024

Conversation

luisecm
Copy link
Contributor

@luisecm luisecm commented Feb 2, 2024

What this PR does 📖

  • Trying using flag images instead of emojis on Settings - About - Made In
  • Added flag image files back and updated css file to add class .flags for these
  • Updated about.rs to use image files instead of emojis
  • Updated wix file so these images can be managed correctly by the windows installer

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@luisecm luisecm added the Draft PR is still a draft and needs more work label Feb 2, 2024
@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev linter failing Cargo Workflow (linter) failed on this PR labels Feb 2, 2024
@stavares843 stavares843 removed the Missing dev review Still needs to be reviewed by a dev label Feb 2, 2024
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed linter failing Cargo Workflow (linter) failed on this PR labels Feb 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@luisecm luisecm removed the Draft PR is still a draft and needs more work label Feb 2, 2024
@stavares843 stavares843 merged commit 9320045 into dev Feb 2, 2024
8 checks passed
@stavares843 stavares843 deleted the luis/flags-wix branch February 2, 2024 22:07
@github-actions github-actions bot removed Don't merge yet DO NOT MERGE Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

Assignees

@luisecm luisecm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisecm @stavares843 @phillsatellite