Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(aria): adding aria labels for settings keybinds and others #1827

Merged
merged 2 commits into from
Feb 6, 2024
Merged

add(aria): adding aria labels for settings keybinds and others #1827

merged 2 commits into from
Feb 6, 2024

Conversation

luisecm
Copy link
Contributor

@luisecm luisecm commented Feb 6, 2024

What this PR does 📖

  • Adding aria labels for Keybinds Settings section (including adding settings for kit element and settings keybinds file)
  • Adding aria labels for flags images used on Settings About
  • Adding aria labels for checkbox kit element and then later used in Settings Profile - checkbox to store seed recovery seed

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Feb 6, 2024
@stavares843 stavares843 removed the Missing dev review Still needs to be reviewed by a dev label Feb 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@stavares843 stavares843 merged commit a74c56a into dev Feb 6, 2024
8 checks passed
@stavares843 stavares843 deleted the luis/arias branch February 6, 2024 21:37
@github-actions github-actions bot removed the Don't merge yet DO NOT MERGE label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

Assignees

@luisecm luisecm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisecm @stavares843 @phillsatellite