Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat): Fix some url highlight things #1862

Merged
merged 3 commits into from
Feb 22, 2024
Merged

fix(chat): Fix some url highlight things #1862

merged 3 commits into from
Feb 22, 2024

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Fixes markdown preview in chatbar sometimes highlighting non url things if provided e.g. as
    ![Image](data:text/html;base64,PHNjcmlwdD5hbGVydCgiSGVsbG8sIFdvcmxkISIpPC9zY3JpcHQ+Cg==)
    now with this pr for
    [url](https://github.com/Satellite-im/Uplink/issues/1818)
    only inner url will be highlighted just as messages.

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Feb 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2024 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

523 tests   471 ✅  3h 1m 46s ⏱️
 44 suites   52 💤
  3 files      0 ❌

Results for commit 3ef141a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Feb 20, 2024
@phillsatellite phillsatellite added the Waiting for CI Waiting for at least one CI job to complete before merging label Feb 21, 2024
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Feb 21, 2024
@phillsatellite phillsatellite removed the Waiting for CI Waiting for at least one CI job to complete before merging label Feb 21, 2024
@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Feb 21, 2024
@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Feb 22, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Feb 22, 2024
@stavares843 stavares843 merged commit adb6d43 into dev Feb 22, 2024
10 checks passed
@stavares843 stavares843 deleted the markdown_preview_url_fix branch February 22, 2024 17:12
@github-actions github-actions bot removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

@dariusc93 dariusc93 dariusc93 approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(chat): exclude link markdown preview in chatbar
4 participants
@Flemmli97 @dariusc93 @stavares843 @phillsatellite