Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contextmenu): dont show empty context menus #1878

Merged
merged 4 commits into from
Feb 28, 2024
Merged

fix(contextmenu): dont show empty context menus #1878

merged 4 commits into from
Feb 28, 2024

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Makes it so if there are no elements in a context menu right clicking will not show it

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev invalid PR title Lint title job failed for this PR labels Feb 27, 2024
@stavares843 stavares843 changed the title fix(context_menu): Dont show empty context menus fix(context menu): Dont show empty context menus Feb 27, 2024
@Satellite-im Satellite-im deleted a comment from github-actions bot Feb 27, 2024
@stavares843 stavares843 changed the title fix(context menu): Dont show empty context menus fix(contextmenu): Dont show empty context menus Feb 27, 2024
@stavares843 stavares843 removed the invalid PR title Lint title job failed for this PR label Feb 27, 2024
@Satellite-im Satellite-im deleted a comment from github-actions bot Feb 27, 2024
@stavares843 stavares843 changed the title fix(contextmenu): Dont show empty context menus fix(contextmenu): dont show empty context menus Feb 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2024 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

525 tests   473 ✅  3h 4m 55s ⏱️
 44 suites   52 💤
  3 files      0 ❌

Results for commit 10bc0ec.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Feb 27, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Feb 28, 2024
@stavares843 stavares843 added Waiting for CI Waiting for at least one CI job to complete before merging and removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Feb 28, 2024
@stavares843 stavares843 merged commit f2bf650 into dev Feb 28, 2024
7 checks passed
@stavares843 stavares843 deleted the context_menu_fix branch February 28, 2024 17:49
@github-actions github-actions bot removed the Waiting for CI Waiting for at least one CI job to complete before merging label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

@dariusc93 dariusc93 dariusc93 approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(groups): Empty context menu when not allowed any actions
4 participants
@Flemmli97 @dariusc93 @stavares843 @phillsatellite