chore(msg): UUID pending msg tracking #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Don't merge yet
UI Automated Test Results Summary for MacOS/Windows540 tests 497 ✅ 3h 13m 41s ⏱️ Results for commit 5485459. ♻️ This comment has been updated with latest results. |
|
UI Automated Tests execution is complete! You can find the test results report here |
dariusc93
reviewed
Mar 8, 2024
Co-authored-by: Darius Clark <dariusc93@users.noreply.github.com>
github-actions
bot
added
Failed Automated Test
phillsatellite
approved these changes
Mar 14, 2024
dariusc93
approved these changes
Mar 14, 2024
dariusc93
added
Ready to Merge
phillsatellite
added
the
Hold For Discussion
|
@lgmarchi wants to take a look at this just to make sure before we merge he wont have too many conflicts with it |
phillsatellite
added
QA Tested
github-actions
bot
removed
QA Tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Previously those where identified by their attachment + text content which was not ideal. With a change in warp though where warp immediately sends back the messages uuid we can now use the uuid to identify messages