Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cargo): Update warp dependency #1935

Merged
merged 21 commits into from
Mar 22, 2024
Merged

chore(cargo): Update warp dependency #1935

merged 21 commits into from
Mar 22, 2024

Conversation

dariusc93
Copy link
Contributor

@dariusc93 dariusc93 commented Mar 20, 2024

What this PR does 📖

  • Allow attachments to be stored in a specific directory per conversations in constellation (if uploading from disk)
  • Encrypt specific data in the root document
  • Stores conversations in root document
  • Pin root document on shuttle instead of storing a specific payload
  • Change how messages are stored and handled internally
  • Increase file attachment from 8 to 32
  • Misc cleanup
  • Allow unsent messages to be retrieved from shuttle on after connecting.
  • Add location to attachment kind

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

  • Due to some of the changes, this PR will not be compatible with previous commits.
  • Messages structure differs and may require one to delete old conversations and create new ones or use a new account.
  • Messages will be fetch a few seconds after coming online and will check at a duration if any is on the node.

Additional comments 🎤

  • This PR also removes some dependencies (which should reduce the dependency tree)
  • File attached from disk will be stored in a specific directory for the conversation while files in constellation will not be copied or moved to that directory
  • While shuttle will pin root the document, there wont be any acknowledgement that is has successfully done so at this time. This may change in the future that specific events would be emitted.
  • At this time, offline messages are intended for those who were apart of the conversation at the time messages were sent. For direct messages, this will be fine as both parties would be apart of the conversation, however for group chat, this would not allow new members to see previously sent messages, largely due to how group chats are designed.
  • Before this PR is merged, the node address will be changed as the current node supplied in the PR is pointed to a test node.

@dariusc93 dariusc93 self-assigned this Mar 20, 2024
@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Mar 20, 2024
@dariusc93 dariusc93 added the Draft PR is still a draft and needs more work label Mar 20, 2024
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Mar 21, 2024
Copy link
Contributor

github-actions bot commented Mar 21, 2024

UI Automated Test Results Summary for MacOS/Windows

500 tests   457 ✅  3h 11m 2s ⏱️
 45 suites   43 💤
  3 files      0 ❌

Results for commit f0d3ed8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 21, 2024

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Mar 22, 2024
@dariusc93 dariusc93 removed the Draft PR is still a draft and needs more work label Mar 22, 2024
@dariusc93 dariusc93 marked this pull request as ready for review March 22, 2024 06:58
@dariusc93 dariusc93 added the Ready for testing Ready for QA to test label Mar 22, 2024
@github-actions github-actions bot added linter failing Cargo Workflow (linter) failed on this PR and removed linter failing Cargo Workflow (linter) failed on this PR labels Mar 22, 2024
@stavares843 stavares843 added being tested and removed Ready for testing Ready for QA to test labels Mar 22, 2024
@stavares843 stavares843 merged commit c1161e5 into dev Mar 22, 2024
27 of 37 checks passed
@stavares843 stavares843 deleted the chore/update/warp-r8 branch March 22, 2024 20:32
@github-actions github-actions bot removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE being tested labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants