feat(settings): Implement missing calltimer setting #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Don't merge yet
UI Automated Test Results Summary for MacOS/Windows392 tests 365 ✅ 2h 33m 49s ⏱️ For more details on these failures and errors, see this check. Results for commit 3f9e65a. ♻️ This comment has been updated with latest results. |
|
UI Automated Tests execution is complete! You can find the test results report here |
|
@Flemmli97 @stavares843 @phillsatellite The automated tests for mac and windows are failing now because currently in dev, Call Timer is set as disabled by default, and on this branch, the Call Timer is enabled by default I can quickly update the tests to reflect this change once this PR is merged, in case that having this setting enabled by default is fine On Dev:
On this branch:
|
phillsatellite
approved these changes
Mar 26, 2024
stavares843
approved these changes
Mar 26, 2024
phillsatellite
added
QA Tested
github-actions
bot
added
the
Failed Automated Test
dariusc93
approved these changes
Mar 28, 2024
dariusc93
added
Ready to Merge
phillsatellite
added
Waiting for CI
github-actions
bot
added
the
Failed Automated Test
github-actions
bot
added
Failed Automated Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Which issue(s) this PR fixes 🔨