Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(themes): Change accent text color #1947

Merged
merged 4 commits into from
Mar 28, 2024
Merged

fix(themes): Change accent text color #1947

merged 4 commits into from
Mar 28, 2024

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Changes the text color based on the accent color. If color is bright it switches to the dark text color

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Mar 26, 2024
@phillsatellite
Copy link
Contributor

Noticed that attachment text still remains white and is very hard to see

Screenshot 2024-03-26 at 12 05 06 PM

@phillsatellite phillsatellite added the Changes requested When other dev or QA request a change label Mar 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@Flemmli97 Flemmli97 removed the Changes requested When other dev or QA request a change label Mar 26, 2024
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Mar 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

511 tests   464 ✅  3h 1m 7s ⏱️
 45 suites   47 💤
  3 files      0 ❌

Results for commit 99f514f.

♻️ This comment has been updated with latest results.

@phillsatellite phillsatellite added Waiting for CI Waiting for at least one CI job to complete before merging and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Mar 26, 2024
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Mar 26, 2024
@phillsatellite phillsatellite added QA Tested QA has tested and approved and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised Waiting for CI Waiting for at least one CI job to complete before merging labels Mar 26, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Mar 28, 2024
@phillsatellite phillsatellite merged commit ab044ec into dev Mar 28, 2024
10 checks passed
@phillsatellite phillsatellite deleted the accent_text_color branch March 28, 2024 16:34
@github-actions github-actions bot removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

@dariusc93 dariusc93 dariusc93 approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task(themes): Text isnt visible with different color themes
4 participants
@Flemmli97 @phillsatellite @dariusc93 @stavares843