fix(themes): Text selection color #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Don't merge yet
|
Hey @Flemmli97 👋 When Sara and I tested it seemed to be almost the same as dev This branch Dev branch |
UI Automated Test Results Summary for MacOS/Windows507 tests 464 ✅ 3h 5m 35s ⏱️ Results for commit c9bbfb0. ♻️ This comment has been updated with latest results. |
|
UI Automated Tests execution is complete! You can find the test results report here |
|
i now added an alpha value (of 0.4 cause that seems apparently the default on mac). can you try and see how it looks? on mac this makes it sometimes look different though than before original now: |
phillsatellite
approved these changes
Mar 28, 2024
stavares843
approved these changes
Mar 28, 2024
dariusc93
approved these changes
Mar 29, 2024
dariusc93
added
Ready to Merge
github-actions
bot
removed
QA Tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
#ff00ff) or an alpha value of 1 (e.g.#ff00ffff). This seems to only apply to macos though as just judging from the linked issue on windows the color gets applied as it is causing the problem.This makes a consistent ui kinda hard.
Which issue(s) this PR fixes 🔨