Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(warp): Drop unneeeded spawn_blocking #1954

Merged
merged 5 commits into from
Mar 29, 2024
Merged

chore(warp): Drop unneeeded spawn_blocking #1954

merged 5 commits into from
Mar 29, 2024

Conversation

zeenix
Copy link
Contributor

@zeenix zeenix commented Mar 28, 2024

What this PR does 📖

Make use of tokio's async API.

@github-actions GitHub Actions
Copy link
Contributor

⚠️ The title of this PR is invalid.
Please make the title match the regex (?:add|update|task|chore|feat|fix|refactor)\([a-z-A-Z]+\):\s.+.
e.g.) add(cli): enable --verbose flag, fix(api): avoid unexpected error in handler

@github-actions github-actions bot added the invalid PR title Lint title job failed for this PR label Mar 28, 2024
@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Mar 28, 2024
@zeenix zeenix changed the title chore(warp_runner): Drop unneeeded spawn_blocking chore: Drop unneeeded spawn_blocking Mar 28, 2024
@zeenix zeenix changed the title chore: Drop unneeeded spawn_blocking chore(warp): Drop unneeeded spawn_blocking Mar 28, 2024
@github-actions github-actions bot removed the invalid PR title Lint title job failed for this PR label Mar 28, 2024
dariusc93
dariusc93 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small comment but besides that LGTM

common/src/warp_runner/mod.rs Outdated Show resolved Hide resolved
@Satellite-im Satellite-im deleted a comment from github-actions bot Mar 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

UI Automated Test Results Summary for MacOS/Windows

507 tests   464 ✅  2h 59m 59s ⏱️
 44 suites   43 💤
  3 files      0 ❌

Results for commit 7d6e9d4.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 29, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@dariusc93 dariusc93 added checking stuff Waiting for CI Waiting for at least one CI job to complete before merging and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE checking stuff labels Mar 29, 2024
@phillsatellite phillsatellite merged commit fd894b9 into dev Mar 29, 2024
6 checks passed
@phillsatellite phillsatellite deleted the chore/drop-spawn-blocking branch March 29, 2024 01:58
@github-actions github-actions bot removed the Waiting for CI Waiting for at least one CI job to complete before merging label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@dariusc93 dariusc93 dariusc93 approved these changes

Assignees

@zeenix zeenix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeenix @dariusc93 @phillsatellite @stavares843