Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keybindings): Fix multiple keybind recording at once #1958

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Fixes being able to record multiple keybinds at once (e.g. via pressing and holding down tab)

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

UI Automated Test Results Summary for MacOS/Windows

507 tests   447 ✅  3h 8m 45s ⏱️
 44 suites   60 💤
  3 files      0 ❌

Results for commit 9522b8f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

UI Automated Tests execution is complete! You can find the test results report here

@phillsatellite phillsatellite added QA Tested QA has tested and approved and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Apr 2, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Apr 3, 2024
@stavares843 stavares843 merged commit b04d9c1 into dev Apr 3, 2024
12 checks passed
@stavares843 stavares843 deleted the keybind_set_fix branch April 3, 2024 22:56
@github-actions github-actions bot removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(keybindings): Holding tab in keybinds will enable all keybind selectors and make the screen black
4 participants