Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): rfd import for file dialog fix #1978

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Adds rfd import to main.lib to fix an issue on macos with opening a file dialog. It has a comment there indicating the problem/fix.

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Apr 17, 2024
@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Apr 17, 2024
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Apr 17, 2024
Copy link
Contributor

UI Automated Test Results Summary for MacOS/Windows

511 tests   451 ✅  2h 57m 32s ⏱️
 45 suites   60 💤
  3 files      0 ❌

Results for commit 9593de3.

Copy link
Contributor

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Apr 17, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Apr 18, 2024
@dariusc93 dariusc93 merged commit 7542668 into dev Apr 18, 2024
10 checks passed
@dariusc93 dariusc93 deleted the file_dialog_crash_fix branch April 18, 2024 17:05
@github-actions github-actions bot removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants