Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat): Dont stop profile fetching when one errors #1979

Merged
merged 11 commits into from
May 23, 2024
Merged

fix(chat): Dont stop profile fetching when one errors #1979

merged 11 commits into from
May 23, 2024

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Makes it so when banner/profile errors during fetching the whole thing is not aborted. This MIGHT fix the linked issue where one person changes their profile picture, another tries to add them but only sees a blank profile picture.
    I was only able to reproduce the linked issue once (might be due to some caching thing maybe?) so not really able to confirm this but it seemed to be a good point here.

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Apr 17, 2024
stavares843
stavares843 reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de ecrã 2024-04-17, às 16 37 30

i know you mentioned it "might fix" the issue but just to let you know that still has some blank avatars on this branch

macOS, m1

@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Apr 17, 2024
@phillsatellite
Copy link
Contributor

I also had Windows account update their picture and as soon as they did it appeared grey for MacOS user
image

Screenshot 2024-04-17 at 11 42 21 AM

@phillsatellite phillsatellite added the Changes requested When other dev or QA request a change label Apr 17, 2024
@Flemmli97
Copy link
Collaborator Author

can you post the logs during it?

@stavares843
Copy link
Member 


sara@MBP-PRO-M1-Sara Uplink % cargo run
   Compiling uplink v1.0.2 (/Users/sara/Uplink/ui)
    Finished dev [unoptimized] target(s) in 14.49s
     Running `target/debug/uplink`
2024-04-17 18:26:55 | DEBUG | starting uplink
2024-04-17 18:26:55 | DEBUG | warp initialization
2024-04-17 18:26:55 | DEBUG | add_to_themes: /Users/sara/.uplink/themes
2024-04-17 18:26:55 | DEBUG | add_to_themes: ui/extra/themes
2024-04-17 18:26:55 | DEBUG | shuttle addresses: ["/ip4/159.65.41.31/tcp/8848/p2p/12D3KooWRF2bz3KDRPvBs1FASRDRk7BfdYc1RUcfwKsz7UBEu7mL"]
2024-04-17 18:26:55 | DEBUG | starting automute
2024-04-17 18:26:55 | DEBUG | starting automute helper
2024-04-17 18:26:55 | DEBUG | add_to_themes: /Users/sara/.uplink/themes
2024-04-17 18:26:55 | DEBUG | add_to_themes: ui/extra/themes
2024-04-17 18:26:55 | DEBUG | add_to_themes: /Users/sara/.uplink/themes
2024-04-17 18:26:55 | DEBUG | add_to_themes: ui/extra/themes
2024-04-17 18:26:55 | DEBUG | received warp cmd: Tesseract { AccountExists } 
2024-04-17 18:26:55 | DEBUG | account_exists: true
2024-04-17 18:26:58 | DEBUG | received warp cmd: MultiPass { TryLogIn } 
2024-04-17 18:26:58 | DEBUG | add_to_themes: /Users/sara/.uplink/themes
2024-04-17 18:26:58 | DEBUG | add_to_themes: ui/extra/themes
2024-04-17 18:26:58 | DEBUG | warp_runner::manager::run
2024-04-17 18:26:58 | DEBUG | state::mutate: SidebarHidden: true
2024-04-17 18:26:58 | DEBUG | add_to_themes: /Users/sara/.uplink/themes
2024-04-17 18:26:58 | DEBUG | add_to_themes: ui/extra/themes
2024-04-17 18:26:58 | DEBUG | state::mutate: RegisterExtensions
2024-04-17 18:26:58 | DEBUG | Loaded 0 extensions.
2024-04-17 18:26:58 | DEBUG | WARP CMD: RayGun { InitializeWarp } 
2024-04-17 18:26:58 | DEBUG | WARP CMD: Constellation { GetItemsFromCurrentDirectory } 
2024-04-17 18:26:58 | DEBUG | Updating directories opened to browse
2024-04-17 18:26:58 | INFO | Get items from current directory worked!
2024-04-17 18:26:58 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture } 
2024-04-17 18:26:58 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture } 
2024-04-17 18:26:58 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture } 
2024-04-17 18:26:58 | DEBUG | WARP CMD: RayGun { FetchMessages } 
2024-04-17 18:26:58 | DEBUG | init_chat_data
2024-04-17 18:26:58 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture } 
2024-04-17 18:26:58 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture } 
2024-04-17 18:26:58 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture } 
2024-04-17 18:26:59 | DEBUG | use_effect for init_msg_scroll 9eaeed37-3c38-d90c-5abb-655680ebe018
2024-04-17 18:27:08 | DEBUG | received multipass event: IdentityOnline { did: did:key:z6Mku7poUPEPmD6eXBrodVMp7ESCRbg67mDbkZ4LAqBjYxfy }
2024-04-17 18:27:08 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture } 
2024-04-17 18:27:08 | DEBUG | process_warp_event: MultiPassEvent { FriendOnline } 
2024-04-17 18:27:08 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture } 
2024-04-17 18:27:12 | DEBUG | received multipass event: IdentityUpdate { did: did:key:z6Mku7poUPEPmD6eXBrodVMp7ESCRbg67mDbkZ4LAqBjYxfy }
2024-04-17 18:27:12 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture } 
2024-04-17 18:27:12 | DEBUG | process_warp_event: MultiPassEvent { IdentityUpdate } 
2024-04-17 18:27:12 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture } 
2024-04-17 18:27:16 | DEBUG | received multipass event: IdentityUpdate { did: did:key:z6Mku7poUPEPmD6eXBrodVMp7ESCRbg67mDbkZ4LAqBjYxfy }
2024-04-17 18:27:16 | DEBUG | process_warp_event: MultiPassEvent { IdentityUpdate } 
2024-04-17 18:27:16 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture } 
2024-04-17 18:27:16 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture } 
2024-04-17 18:27:17 | DEBUG | received multipass event: IdentityUpdate { did: did:key:z6Mku7poUPEPmD6eXBrodVMp7ESCRbg67mDbkZ4LAqBjYxfy }
2024-04-17 18:27:17 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture } 
2024-04-17 18:27:17 | DEBUG | process_warp_event: MultiPassEvent { IdentityUpdate } 
2024-04-17 18:27:17 | DEBUG | WARP CMD: MultiPass { UpdateProfilePicture }

you want any specific flag?

@Flemmli97
Copy link
Collaborator Author

i think errors are on by default anyways right? if so no

@stavares843
Copy link
Member

i believe so yes

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

514 tests   457 ✅  3h 24m 2s ⏱️
 45 suites   57 💤
  3 files      0 ❌

Results for commit 6d69b3c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Apr 17, 2024
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Apr 29, 2024
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label May 3, 2024
@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label May 8, 2024
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised labels May 20, 2024
@stavares843 stavares843 merged commit 6890973 into dev May 23, 2024
6 of 7 checks passed
@stavares843 stavares843 deleted the profile_fetch_fix branch May 23, 2024 14:43
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed Changes requested When other dev or QA request a change Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavares843 stavares843 stavares843 approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
Failed Automated Test This PR is failing Luis's Appium test and needs revised
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(chat): custom profile picture will be missing when adding friends
5 participants
@Flemmli97 @phillsatellite @stavares843 @luisecm @dariusc93