Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): fix build windows issue on no media found #1985

Merged
merged 1 commit into from
May 6, 2024
Merged

chore(build): fix build windows issue on no media found #1985

merged 1 commit into from
May 6, 2024

Conversation

luisecm
Copy link
Contributor

@luisecm luisecm commented May 6, 2024

What this PR does 📖

  • After doing some research on the no media found issue for build windows workflow, it looks like D:\ media is not detected on GH workflow for the copy repo. Using C:\certificate.p12 instead of d\certificate.p12 as temporary path for the cert and adding step to remove it before finishing job

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels May 6, 2024
@phillsatellite phillsatellite removed the Missing dev review Still needs to be reviewed by a dev label May 6, 2024
@phillsatellite phillsatellite merged commit b8aca66 into dev May 6, 2024
3 checks passed
@phillsatellite phillsatellite deleted the luis/buid-action-win branch May 6, 2024 16:36
@github-actions github-actions bot removed the Don't merge yet DO NOT MERGE label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees

@luisecm luisecm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luisecm @phillsatellite