Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add/update host_new entities & views #1300

Merged
merged 1 commit into from
Apr 8, 2024
Merged

add/update host_new entities & views #1300

merged 1 commit into from
Apr 8, 2024

Conversation

amolpati30
Copy link
Contributor

@amolpati30 amolpati30 commented Mar 28, 2024 •
edited
Loading

i have made some small changes and added one airgun entities and views for host_new module.
below test_case is depending on given changes.

Dependent PR: SatelliteQE/robottelo#14556

@amolpati30 amolpati30 added CherryPick PR needs CherryPick to previous branches 6.14.z 6.15.z labels Mar 28, 2024
@shubhamsg199 shubhamsg199 added the AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing label Mar 28, 2024
@amolpati30 amolpati30 mentioned this pull request Mar 28, 2024
Merged
omkarkhatavkar
omkarkhatavkar suggested changes Mar 29, 2024
View reviewed changes
Copy link

@omkarkhatavkar omkarkhatavkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the hard sleep and move that to wait_for

@omkarkhatavkar
Copy link

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py -k test_positive_add_and_remove_ansible_role_in_new_ui
robottelo: 14556

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 232
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py -k test_positive_add_and_remove_ansible_role_in_new_ui --external-logging
Test Result : =========== 1 passed, 8 deselected, 9 warnings in 750.95s (0:12:30) ============

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 2, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 3, 2024
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py -k test_positive_assign_and_remove_ansible_role_in_new_ui
robottelo: 14556

@omkarkhatavkar
Copy link

@amolpati30 Nice Work !

@omkarkhatavkar omkarkhatavkar merged commit fb5e1fd into master Apr 8, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
@amolpati30 @web-flow
add/update host_new entities & views (#1300)
1550a51 
(cherry picked from commit fb5e1fd)
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
@amolpati30 @web-flow
add/update host_new entities & views (#1300)
3236bfb 
(cherry picked from commit fb5e1fd)
This was referenced Apr 8, 2024
Merged
Merged
Satellite-QE added a commit that referenced this pull request Apr 8, 2024
@Satellite-QE
add/update host_new entities & views (#1300) (#1313)
927d7f0
Satellite-QE added a commit that referenced this pull request Apr 8, 2024
@Satellite-QE
add/update host_new entities & views (#1300) (#1314)
53b0b90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

Assignees

@amolpati30 amolpati30

Labels
6.14.z 6.15.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amolpati30 @omkarkhatavkar @Satellite-QE @shubhamsg199