Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait for a dashboard card to load #1556

Merged
merged 1 commit into from
Sep 12, 2024
Merged

wait for a dashboard card to load #1556

merged 1 commit into from
Sep 12, 2024

Conversation

pondrejk
Copy link
Contributor

similar to #1555

@pondrejk pondrejk added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing 6.15.z 6.16.z labels Sep 11, 2024
@pondrejk pondrejk self-assigned this Sep 11, 2024
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_remoteexecution.py -k test_positive_run_default_job_template
airgun: 1556

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 402
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_remoteexecution.py -k test_positive_run_default_job_template --external-logging
Test Result : ========== 1 passed, 7 deselected, 22 warnings in 1032.75s (0:17:12) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 11, 2024
sambible
sambible approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as opposed to hard sleeps as some other reviewers, it can be an effective tool to resolve very unfortunate disconnects between PRT/Local runs and CI.

Approving this, and will also be approving #1555

@sambible sambible mentioned this pull request Sep 12, 2024
Merged
LadislavVasina1
LadislavVasina1 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, I agree with @sambible comment

@LadislavVasina1 LadislavVasina1 merged commit cb109c1 into SatelliteQE:master Sep 12, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 12, 2024
@pondrejk @web-flow
wait for a dashboard card to load (#1556)
bb5746d 
(cherry picked from commit cb109c1)
github-actions bot pushed a commit that referenced this pull request Sep 12, 2024
@pondrejk @web-flow
wait for a dashboard card to load (#1556)
d75c5a7 
(cherry picked from commit cb109c1)
This was referenced Sep 12, 2024
Merged
Open
Satellite-QE added a commit that referenced this pull request Sep 12, 2024
@Satellite-QE
wait for a dashboard card to load (#1556) (#1560)
0005b5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambible sambible sambible approved these changes

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

Assignees

@pondrejk pondrejk

Labels
6.15.z 6.16.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pondrejk @Satellite-QE @sambible @LadislavVasina1