Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Airgun CI/CQ to uv #1685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ogajduse
Copy link
Member

This PR switches pip to uv as @JacobCallahan requested in the chat.

@ogajduse ogajduse added CherryPick PR needs CherryPick to previous branches 6.13.z 6.14.z 6.15.z maintenance Repository maintenance work 6.16.z labels Dec 19, 2024
@ogajduse ogajduse self-assigned this Dec 19, 2024
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
Comment on lines 70 to 71
- name: Set up uv
run: curl -LsSf https://astral.sh/uv/install.sh | sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also move to using this: https://github.com/astral-sh/setup-uv

not a blocker though, since this works fine as well

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.astral.sh/uv/guides/integration/github/ has plenty of recommendations on how to do that, including caching.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, I saw your suggestion just now. I figured it out independently. I have just pushed the change. Let's check the results...

@ogajduse ogajduse force-pushed the ci/switch-gha-to-uv branch 5 times, most recently from 6245bc5 to 8bea710 Compare December 19, 2024 20:23
@ogajduse ogajduse force-pushed the ci/switch-gha-to-uv branch from 8bea710 to 89365e2 Compare December 19, 2024 20:53
@ogajduse ogajduse marked this pull request as ready for review December 19, 2024 21:01
@ogajduse ogajduse requested a review from ekohl December 19, 2024 21:01
Copy link

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner now with this action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z 6.14.z 6.15.z 6.16.z CherryPick PR needs CherryPick to previous branches maintenance Repository maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants