Rework inventory cli #324
Merged
Rework inventory cli #324
+195
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobCallahan
added
enhancement
JacobCallahan
commented
Oct 7, 2024
JacobCallahan
commented
Oct 8, 2024
With the changes we've been making in 0.6 toward a better, more customizable and visually appealing, user experience. It's time that we revisited the inventory command. The --curated view introduced in 0.5.x has now become the default inventory view. The original default view is now present in its new form and home with the --list flag. The --details flag largely retains the functionality it did before. However, it involves much less processing than before. One important piece added in this is the ability to customize the inventory fields on a per-user basis. The details on this customization are documented in detail in the supporting code. It will also be important to document this in the wiki upon release.
JacobCallahan
force-pushed
the
inventory_refactor
branch
from
a76d0ea to
dada892
Compare
In case people want to have a more plain output.
|
@ogajduse enjoy.... lol |
JacobCallahan
force-pushed
the
inventory_refactor
branch
from
2734d24 to
70de788
Compare
I had forgot the include logic to not run some migrations if the changes have already taken place. This skip is just the "naive" approach instead of doing a complete validation that the previous fields have migrated.
JacobCallahan
force-pushed
the
inventory_refactor
branch
from
70de788 to
6c3797a
Compare
tpapaioa
requested changes
Oct 10, 2024
Co-authored-by: Tasos Papaioannou <tpapaioa@redhat.com>
tpapaioa
approved these changes
Oct 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes we've been making in 0.6 toward a better, more customizable and visually appealing, user experience. It's time that we revisited the inventory command.
The --curated view introduced in 0.5.x has now become the default inventory view. The original default view is now present in its new form and home with the --list flag.
The --details flag largely retains the functionality it did before. However, it involves much less processing than before.
One important piece added in this is the ability to customize the inventory fields on a per-user basis. The details on this customization are documented in detail in the supporting code.
It will also be important to document this in the wiki upon release.
Here's a screenshot of what the new changes look like (with the details view cut-off for security).
