Add initial helper scripts #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two new helper scripts that are useful when working with large comparisons. scripts/gen_constants.py creates a constants file that can help reduce the number of constants generated in a comparison. scripts/clean_csv.py performs a number of simplifications of a csv file and creates a new output that is much easier for a human to review. One important note here is that the resulting report is not a valid csv file.
jyejare
reviewed
Jun 28, 2024
There was a problem hiding this comment.
@JacobCallahan I think both these scripts are eligible for new reporting subcommand in candore that helps to play with reports.
I can do that later though and we review/merge it as is if the time does not permits you.
|
@jyejare interesting thought. I'm not sure how that command would be structured right now, so we can implement that later. |
jyejare
approved these changes
Jul 11, 2024
jyejare
reviewed
Jul 11, 2024
| csv.field_size_limit(sys.maxsize) | ||
|
|
||
|
|
||
| def filter_parts(parts): |
There was a problem hiding this comment.
What does a CSV should have that mark it as an expected constant ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new helper scripts that are useful when working with large comparisons.
scripts/gen_constants.py creates a constants file that can help reduce the number of constants generated in a comparison. scripts/clean_csv.py performs a number of simplifications of a csv file and creates a new output that is much easier for a human to review. One important note here is that the resulting report is not a valid csv file.