Add subscription_allocations property #25
Conversation
As part of the Manifester inventory management effort, this PR adds a `subscription_allocations` property (filtered by the `username_prefix` setting) to the `Manifester` object. To enable this change, it abstracts the paginated API data processing functionaliy from the `subscription_pools` property to a helper function capable of handling GET requests to either the `allocations` or `pools` endpoints. Additionally, this PR adds a new unit test and mock endpoint to the RhsmApiStub class's `get()` method.
| manifest_category=manifest_data, requester=RhsmApiStub(in_dict=None, has_offset=True) | ||
| ) | ||
| for allocation in manifester.subscription_allocations: | ||
| assert allocation["name"].startswith(manifest_data["username_prefix"]) |
There was a problem hiding this comment.
Is there a length of allocations we should also assert for to make sure it's returning the total you expect?
There was a problem hiding this comment.
I don't think so. One of the end goals of this effort is to provide users with a mechanism to clean up their existing subscription allocations, particularly ones of which they are unaware (e.g. allocations that were not cleaned up properly due to test interruption). So having an expectation on the number of allocations returned would be at cross purposes to that goal, in my thinking.
|
@Griffin-Sullivan If I understand you correctly regarding the redundancy in |
As part of the Manifester inventory management effort, this PR adds a
subscription_allocationsproperty (filtered by theusername_prefixsetting) to theManifesterobject. To enable this change, it abstracts the paginated API data processing functionaliy from thesubscription_poolsproperty to a helper function capable of handling GET requests to either theallocationsorpoolsendpoints.Additionally, this PR adds a new unit test and mock endpoint to the RhsmApiStub class's
get()method.