Add Dockerfile #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a Dockerfile for container image builds. Additionally, fixed some small items and added a more permissive flake config
synkd
approved these changes
May 24, 2022
There was a problem hiding this comment.
Looks good to me. @JacobCallahan had asked me specifically to ensure that there were no missing system packages in the dockerfile. I don't believe there are any additional required system package dependencies.
mshriver
reviewed
May 24, 2022
| ENV MANIFESTER_DIRECTORY=/root/manifester/ | ||
| COPY . /root/manifester/ | ||
| RUN pip install . | ||
| RUN cp manifester_settings.yaml.example manifester_settings.yaml |
There was a problem hiding this comment.
Should this really be done in the dockerfile? the github workflow needs it, but I'd expect the runner to mount their config file.
There was a problem hiding this comment.
One of the big reasons for this is to make sure someone can run the dockerfile without mounts to see help output
$ docker run --rm manifester --help master
Usage: manifester [OPTIONS] COMMAND [ARGS]...
Options:
--help Show this message and exit.
Commands:
get-manifest
mshriver
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a Dockerfile for container image builds.
Additionally, fixed some small items and added a more permissive flake
config