Make uuid available #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosas
force-pushed
the
make-uuid-available
branch
from
9ae308b
to
3be1289
Compare
synkd
requested changes
Mar 19, 2024
There was a problem hiding this comment.
Thank you for the PR. I'm requesting a change based on a quirk of how Manifester's unit tests are implemented. This change should both pass the unit tests and function in normal use (whereas self.allocation_uuid.uuid will throw an AttributeError outside of the unit tests).
dosas
force-pushed
the
make-uuid-available
branch
from
3be1289
to
239e99b
Compare
synkd
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described here SatelliteQE/robottelo#14405 (comment) this will make the uuid available