Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repo_data option to host registration command #1210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add repo_data option to host registration command #1210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions nailgun/entities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6795,6 +6795,7 @@ def __init__(self, server_config=None, **kwargs):
'update_packages': entity_fields.BooleanField(default=False),
'force': entity_fields.BooleanField(default=False),
'ignore_subman_errors': entity_fields.BooleanField(default=False),
'repo_data': entity_fields.ListField(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dosas Thanks for adding this. Yes, I saw this option being added in foreman recently, and as per apidoc I see it is a Array with repository URL and corresponding GPG key URL, so I think ListField might not work here, so could you try DictField instead if it doesn't?

Also, I was wondering if you had any robottelo tests covering the repo_data? To verify this, we could run the PRT with that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it is a list of dicts, so ListField should be correct. I have robottelo tests using this feature but they are not upstream.

The tests that are using api_register in robottelo do not use repo_data currently.

}

self._meta = {'api_path': '/api/registration_commands'}
Expand Down
Loading