Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE_CR fix for available images #10765

Merged
merged 1 commit into from
Mar 2, 2023
Merged

GCE_CR fix for available images #10765

merged 1 commit into from
Mar 2, 2023

Conversation

adarshdubey-star
Copy link
Contributor

@adarshdubey-star adarshdubey-star commented Feb 22, 2023 •
edited
Loading

A enhancement done on the wrapanapi to incorporate Projects while listing images : RedHatQE/wrapanapi#461
Test result:

pytest tests/foreman/api/test_computeresource_gce.py -k test_positive_check_available_images
============================================================================ test session starts ============================================================================
platform linux -- Python 3.11.1, pytest-7.2.1, pluggy-1.0.0
shared_function enabled - OFF - scope:  - storage: file
rootdir: /home/addubey/work/robottelo, configfile: pyproject.toml
plugins: xdist-3.1.0, services-2.2.1, mock-3.10.0, reportportal-5.1.3, ibutsu-2.2.4, cov-3.0.0
collected 9 items / 8 deselected / 1 selected                                                                                                                               

tests/foreman/api/test_computeresource_gce.py .                                                                                                                       [100%]

=============================================================== 1 passed, 8 deselected, 6 warnings in 47.16s ================================================================

@adarshdubey-star adarshdubey-star added API Issues and PRs involving the API 6.11.z Introduced in or relating directly to Satellite 6.11 CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 labels Feb 22, 2023
@adarshdubey-star adarshdubey-star self-assigned this Feb 22, 2023
@adarshdubey-star adarshdubey-star added the in progress This issue is being worked on label Feb 22, 2023
@Gauravtalreja1 Gauravtalreja1 added the QETestCoverage Issues and PRs relating to a Satellite bug label Feb 22, 2023
@Gauravtalreja1
Copy link
Collaborator

Moving this PR to draft until we get wrapanapi PR merged

@Gauravtalreja1 Gauravtalreja1 marked this pull request as draft February 27, 2023 12:45
@adarshdubey-star adarshdubey-star marked this pull request as ready for review March 1, 2023 05:30
@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_computeresource_gce.py -k test_positive_check_available_images

@Gauravtalreja1 Gauravtalreja1 removed the in progress This issue is being worked on label Mar 1, 2023
@adarshdubey-star adarshdubey-star marked this pull request as draft March 1, 2023 15:58
@adarshdubey-star
GCE_CR fix for available images
f6162c7 
Signed-off-by: Adarsh Dubey <addubey@redhat.com>
@adarshdubey-star adarshdubey-star marked this pull request as ready for review March 2, 2023 06:50
@adarshdubey-star
Copy link
Contributor Author

adarshdubey-star commented Mar 2, 2023 •
edited
Loading

PRT is failing because the issue is not fixed/cherrypicked in the stream build, works fine with N-minus versions locally.

@Gauravtalreja1 Gauravtalreja1 merged commit 507456f into SatelliteQE:master Mar 2, 2023
@Satellite-QE Satellite-QE mentioned this pull request Mar 2, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Mar 2, 2023
@adarshdubey-star @web-flow
GCE_CR fix for available images (#10765)
461d18f 
Signed-off-by: Adarsh Dubey <addubey@redhat.com>
(cherry picked from commit 507456f)
github-actions bot pushed a commit that referenced this pull request Mar 2, 2023
@adarshdubey-star @web-flow
GCE_CR fix for available images (#10765)
085e335 
Signed-off-by: Adarsh Dubey <addubey@redhat.com>
(cherry picked from commit 507456f)
This was referenced Mar 2, 2023
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Mar 2, 2023
@adarshdubey-star @web-flow
GCE_CR fix for available images (#10765)
f52111a 
Signed-off-by: Adarsh Dubey <addubey@redhat.com>
(cherry picked from commit 507456f)
Gauravtalreja1 pushed a commit that referenced this pull request Mar 2, 2023
@Satellite-QE @adarshdubey-star
[6.13.z] GCE_CR fix for available images (#10837)
fb9bdc5 
GCE_CR fix for available images (#10765)

Signed-off-by: Adarsh Dubey <addubey@redhat.com>
(cherry picked from commit 507456f)

Co-authored-by: Adarsh dubey <addubey@redhat.com>
Gauravtalreja1 pushed a commit that referenced this pull request Mar 2, 2023
@Satellite-QE @adarshdubey-star
[6.11.z] GCE_CR fix for available images (#10839)
6eb8c42 
GCE_CR fix for available images (#10765)

Signed-off-by: Adarsh Dubey <addubey@redhat.com>
(cherry picked from commit 507456f)

Co-authored-by: Adarsh dubey <addubey@redhat.com>
Gauravtalreja1 pushed a commit that referenced this pull request Mar 2, 2023
@Satellite-QE @adarshdubey-star
[6.12.z] GCE_CR fix for available images (#10838)
8446649 
* GCE_CR fix for available images (#10765)

Signed-off-by: Adarsh Dubey <addubey@redhat.com>
(cherry picked from commit 507456f)

* Cherrypicking wrapanapi version

Signed-off-by: Adarsh Dubey <addubey@redhat.com>

---------

Signed-off-by: Adarsh Dubey <addubey@redhat.com>
Co-authored-by: Adarsh dubey <addubey@redhat.com>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@adarshdubey-star @shweta83
GCE_CR fix for available images (SatelliteQE#10765)
f6ccde3 
Signed-off-by: Adarsh Dubey <addubey@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@adarshdubey-star adarshdubey-star

Labels
6.11.z Introduced in or relating directly to Satellite 6.11 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 API Issues and PRs involving the API CherryPick PR needs CherryPick to previous branches QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adarshdubey-star @Gauravtalreja1 @ColeHiggins2 @shubhamsg199