Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record start_time property workaround #8122

Merged

Conversation

rplevka
Copy link
Member

@rplevka rplevka commented Nov 4, 2020

This is a workaround for:
pytest-dev/pytest#7767

where the pre-defined record_testsuite_timestamp_xml fixture doesn't work with xdist yet.
This commit keeps the fixture, but sets autouse=False

and implements a manual property recording inside the report_header hook

@rplevka rplevka self-assigned this Nov 4, 2020
@rplevka rplevka requested a review from lpramuk November 4, 2020 11:05
Copy link
Contributor

@tstrych tstrych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ACK

@rplevka rplevka force-pushed the start_time_property_workaround branch from b9ee621 to a3cc0d5 Compare November 4, 2020 12:18
@rplevka
Copy link
Member Author

rplevka commented Nov 4, 2020

thanks @tstrych for discussing the .now() vs .utcnow(). After reviewing the code I realized we actually use .utcnow() in the logger too, so I reverted it back just as you suggested.

@rplevka rplevka force-pushed the start_time_property_workaround branch from a3cc0d5 to a832e20 Compare November 4, 2020 12:21
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #8122 into master will decrease coverage by 0.12%.
The diff coverage is 48.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8122      +/-   ##
==========================================
- Coverage   58.56%   58.44%   -0.13%     
==========================================
  Files          74       77       +3     
  Lines        5795     6235     +440     
==========================================
+ Hits         3394     3644     +250     
- Misses       2401     2591     +190     
Impacted Files Coverage Δ
robottelo/api/assertions.py 100.00% <ø> (ø)
robottelo/cli/activationkey.py 53.48% <ø> (-1.06%) ⬇️
robottelo/cli/architecture.py 100.00% <ø> (ø)
robottelo/cli/assertions.py 100.00% <ø> (ø)
robottelo/cli/computeresource.py 54.83% <ø> (+10.83%) ⬆️
robottelo/cli/contentview.py 47.74% <ø> (+4.61%) ⬆️
robottelo/cli/discoveryrule.py 100.00% <ø> (ø)
robottelo/cli/domain.py 100.00% <ø> (ø)
robottelo/cli/environment.py 71.42% <ø> (-3.58%) ⬇️
robottelo/cli/filter.py 71.42% <ø> (-3.58%) ⬇️
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6737d5...a832e20. Read the comment docs.

@mshriver mshriver added Bug This is an issue with the robottelo framework PytestConversion PRs and Issues related to converting unittest to pytest labels Nov 4, 2020
@mshriver mshriver merged commit 853e56b into SatelliteQE:master Nov 4, 2020
@rplevka rplevka deleted the start_time_property_workaround branch January 28, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is an issue with the robottelo framework PytestConversion PRs and Issues related to converting unittest to pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants