Bug: When only_keep_points_on_transects is True dropped points are not removed from transect_time_series_merged.csv

[2320sharon]

When the user wants to keep only the shoreline points that land on the transect the user sets the 'Drop intersection points not on transects' setting to True. This will drop the shoreline points that land outside the transect, except it does not remove these dropped points transect_time_series_merged.csv files, but does for the transect_time_series.csv files

I have also noticed that the code to add the 'shore_x' and 'shore_y' points to the timeseries file is using the transect point at index =1, which works correctly if the transect contains only 2 points, but will fail to calculate the correct position if the transect contained more than 2 points. This is because the logic assumes that the transect's end point is at index 1 and when this is not the case the shore x and shore y points are calculated relative to the incorrect points.

• In add_shore_points_to_timeseries set last = transect.geometry.coords[-1] instead of last = transect.geometry.coords[1]

• In common.py after filter_dropped_points_out_of_timeseries make sure to drop the points in dropped_points_df from merged_timeseries_df ( this dataframe is later used to create the transect_time_series_merged.csv files

• In scripts/apply_tidal_correction.py after filter_dropped_points_out_of_timeseries make sure to drop the points in dropped_points_df from merged_timeseries_df ( this dataframe is later used to create the transect_time_series_merged.csv files