Added option to download through a proxy

[Diiak]

In connection with the issue I created. I added the option to download through a proxy.

It works with HTTP and SOCKS5 proxies.

For HTTP : spotify_dl -p "http://username:password@hostname:port" or "http://hostname:port"
For SOCKS5 : spotify_dl -p "socks5://username:password@hostname:port" or "socks5://hostname:port"

I hope this will help some people 🚀

[Diiak]

@SathyaBhat Let me know if it's good for you. I saw that there was a problem with the deep analysis but I checked my indentation is correct 😃

[SathyaBhat]

Hi @Diiak - the deepsource complaint is that you use the tab character instead of spaces. Can you correct that? https://deepsource.io/gh/SathyaBhat/spotify-dl/run/3b926209-6a70-43a4-a1a7-7c369c234fb4/python/

Also, could you please update the readme & getting started about the proxy flag?

Thanks!

[Diiak]

@SathyaBhat I don't understand why the download doesn't work. What is the problem? It doesn't seem to be related to the proxy since the tests don't use one 🤔

[SathyaBhat]

it looks like sponsorblock API is causing troubles. Need to check deeper

[Diiak]

it looks like sponsorblock API is causing troubles. Need to check deeper

I was also having problems when testing locally with sponsorblock but the sound was still downloading. Let me know when everything is ok then!

[SathyaBhat]

the download will work, sponsorblock API is used to fetch skippable segments and then the file is converted to mp3. If this is skipped, the file will be downloaded but not converted to mp3. The tests specifically check for this as well, not just the download and hence it fails

[Diiak]

the download will work, sponsorblock API is used to fetch skippable segments and then the file is converted to mp3. If this is skipped, the file will be downloaded but not converted to mp3. The tests specifically check for this as well, not just the download and hence it fails

I understand the concern then. I see on the status page that there are indeed some issues. We'll do the tests again when it's fixed 👍

[Diiak]

@SathyaBhat Hello, It looks like the sponsorblock server is available today. Can we try the tests again?

[SathyaBhat]

@Diiak seems like its still having issues

WARNING: HTTP Error 502: Bad Gateway. Retrying...
WARNING: HTTP Error 502: Bad Gateway. Retrying...
WARNING: HTTP Error 502: Bad Gateway. Retrying...
ERROR: Postprocessing: Unable to communicate with SponsorBlock API: HTTP Error 502: Bad Gateway

would be a good time to fix skip sponsorblock #309