add test, handle Youtube quota expiry better #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SathyaBhat
added a commit
that referenced
this pull request
Mar 28, 2020
* add test, handle Youtube quota expiry better (#68) * Add Github action to release to PyPI
SathyaBhat
added a commit
that referenced
this pull request
Mar 29, 2020
…#71) * add test, handle Youtube quota expiry better (#68) * add sigint handler to handle Ctrl+C better * major version bump due to Python version change (now needs 3.6+) * move sentry around so that github action doesn;t complain when trying to fetch version for publishing * move sentry around * oops, moved signal to wrong place
SathyaBhat
added a commit
that referenced
this pull request
May 9, 2020
* add test, handle Youtube quota expiry better (#68) * add sigint handler to handle Ctrl+C better * major version bump due to Python version change (now needs 3.6+) * move sentry around so that github action doesn;t complain when trying to fetch version for publishing * move sentry around * oops, moved signal to wrong place * Add HTML Scraping functionality * Update requirements.txt to fit HTML Scrape * change the log structure * some additional error handling when scraping fails * tests for getting link w/ scraping * update requirements for packaging Co-authored-by: Luca Koroll <contact@lucakoroll.de>
SathyaBhat
added a commit
that referenced
this pull request
May 9, 2020
* add test, handle Youtube quota expiry better (#68) * add sigint handler to handle Ctrl+C better * major version bump due to Python version change (now needs 3.6+) * move sentry around so that github action doesn;t complain when trying to fetch version for publishing * move sentry around * oops, moved signal to wrong place * Add HTML Scraping functionality * Update requirements.txt to fit HTML Scrape * change the log structure * some additional error handling when scraping fails * tests for getting link w/ scraping * update requirements for packaging * add deepsource Co-authored-by: Luca Koroll <contact@lucakoroll.de>
SathyaBhat
added a commit
that referenced
this pull request
May 10, 2020
* add test, handle Youtube quota expiry better (#68) * add sigint handler to handle Ctrl+C better * major version bump due to Python version change (now needs 3.6+) * move sentry around so that github action doesn;t complain when trying to fetch version for publishing * move sentry around * oops, moved signal to wrong place * Add HTML Scraping functionality * Update requirements.txt to fit HTML Scrape * change the log structure * some additional error handling when scraping fails * tests for getting link w/ scraping * update requirements for packaging * add deepsource * don't show notice about dev key * fix typo in youtube dev key env variable * remove redundant assignment to dev key * try to go via api only if dev key has been set * add local cache spotifydl now saves links to previously scraped URLs to reduce calls to YouTube * scraper is now the default option * fix bug where non-scrape path was applied when it should have been scraped * update reqs to add peewee * save cache to homedir, remove negative tests * merge conflicts * remove unused imports * remove scrape argument * remove unused args * clean up imports * pep8 line breaks * docstrings * remove validate.py, add later * make deepsource happy * skipchecks Co-authored-by: Luca Koroll <contact@lucakoroll.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Youtube expiry better but explicitly mentioning what went wrong