Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sse #85

Merged
merged 6 commits into from
Mar 31, 2024
Merged

feat: sse #85

merged 6 commits into from
Mar 31, 2024

Conversation

Sorikairox
Copy link
Collaborator

Description

New @sse decorator for methods.


Issue Ticket Number

Fixes #(issue_number)


Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run deno lint AND deno fmt AND deno task test and got no
    errors.
  • I have followed the contributing guidelines of this project as mentioned
    in CONTRIBUTING.md
  • I have checked to ensure there aren't other open
    Pull Requests for the same
    update/change?
  • I have performed a self-review of my own code
  • I have made corresponding changes needed to the documentation

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.92%. Comparing base (844627e) to head (63b0507).

❗ Current head 63b0507 differs from pull request most recent head 460f47b. Consider uploading reports for the commit 460f47b to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   93.77%   93.92%   +0.15%     
==========================================
  Files          65       66       +1     
  Lines        1896     1943      +47     
  Branches      211      215       +4     
==========================================
+ Hits         1778     1825      +47     
  Misses        115      115              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great feature! I'm looking forward to it! 😁

src/router/router.ts Outdated Show resolved Hide resolved
src/router/router.ts Show resolved Hide resolved
@Sorikairox Sorikairox merged commit 849863b into main Mar 31, 2024
1 check passed
@Sorikairox Sorikairox deleted the feat/sse branch March 31, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants