-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Version Checks #154
feat: Version Checks #154
Conversation
Hi i don't think that doing a git show is good because people can not have git |
Oh, ur tutorial shows git clone to get the project, so I assume everyone will be doing that, making git available. |
Yeah but sometimes they just download the zip in the releases page and upload them in a vps that don't have git or into a pterodactyl container |
Welp, I'm not sure if there's any other way that doesn't involve adding version tags manually. We could also only support such check if the user has git. |
In the package.json |
And then you can make a request to github to get the latest release in https://github.com/Sayrix/Ticket-Bot/releases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use another method instead of using git
Oh, you keep versions there. That works, I'll just modify some stuff on my end then. |
REST-API based version check is done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested but the code seems to be ok, can you ask to someone to try your code or just say me if you tested it ?
works pretty good. |
Thank you very much for your contribution |
Resolves #152 by comparing remote and local git hashes.