Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Version Checks #154

Merged
merged 3 commits into from
Jun 16, 2023
Merged

feat: Version Checks #154

merged 3 commits into from
Jun 16, 2023

Conversation

zhiyan114
Copy link
Collaborator

Resolves #152 by comparing remote and local git hashes.

@Sayrix
Copy link
Owner

Sayrix commented Jun 16, 2023

Hi i don't think that doing a git show is good because people can not have git

@zhiyan114
Copy link
Collaborator Author

Oh, ur tutorial shows git clone to get the project, so I assume everyone will be doing that, making git available.

@Sayrix
Copy link
Owner

Sayrix commented Jun 16, 2023

Yeah but sometimes they just download the zip in the releases page and upload them in a vps that don't have git or into a pterodactyl container

@zhiyan114
Copy link
Collaborator Author

Welp, I'm not sure if there's any other way that doesn't involve adding version tags manually.

We could also only support such check if the user has git.

@Sayrix
Copy link
Owner

Sayrix commented Jun 16, 2023

In the package.json

@Sayrix
Copy link
Owner

Sayrix commented Jun 16, 2023

And then you can make a request to github to get the latest release in https://github.com/Sayrix/Ticket-Bot/releases

Copy link
Owner

@Sayrix Sayrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use another method instead of using git

@zhiyan114
Copy link
Collaborator Author

Oh, you keep versions there. That works, I'll just modify some stuff on my end then.

@zhiyan114 zhiyan114 marked this pull request as draft June 16, 2023 15:33
@zhiyan114 zhiyan114 marked this pull request as ready for review June 16, 2023 15:57
@zhiyan114
Copy link
Collaborator Author

zhiyan114 commented Jun 16, 2023

REST-API based version check is done

Copy link
Owner

@Sayrix Sayrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but the code seems to be ok, can you ask to someone to try your code or just say me if you tested it ?

@zhiyan114
Copy link
Collaborator Author

works pretty good.

@Sayrix Sayrix merged commit 5d24597 into Sayrix:main Jun 16, 2023
@Sayrix
Copy link
Owner

Sayrix commented Jun 16, 2023

Thank you very much for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect bot updates automatically
2 participants