-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: PostgreSQL Support & fixes #155
Conversation
In the comments of your driver postgre you say that it's taken from the quick.db pre-release but in that case why not wait for quick.db to support it directly rather than using experimental code? |
It seems like all database driver formats are the same for the library. It's stable enough, they're probably waiting a bit longer to add other changes before releasing it. |
Can you try your code and say me if every functions of ticket-bot works ? |
Especially the emojis in the db |
Sure, though, I'll be later tonight since I won't be available near the dev PC for the day |
The emoji won't be a problem, since Postgres already know how to handle that. The only issue I found is the default config table name that I initially set to, which conflicts with SQL's keyword. Other than that, it works like normal. I'll def make another PR once quick.db push out the driver to clean stuff up, tho I do recommend you to plan to move away from |
…t's invalid instead of empty string
PostgreSQL is a popular choice for remote database and better than mysql.
PR also a resolves #156