Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: PostgreSQL Support & fixes #155

Merged
merged 9 commits into from
Jun 18, 2023
Merged

Feat: PostgreSQL Support & fixes #155

merged 9 commits into from
Jun 18, 2023

Conversation

zhiyan114
Copy link
Collaborator

@zhiyan114 zhiyan114 commented Jun 17, 2023

PostgreSQL is a popular choice for remote database and better than mysql.

PR also a resolves #156

@Sayrix
Copy link
Owner

Sayrix commented Jun 17, 2023

In the comments of your driver postgre you say that it's taken from the quick.db pre-release but in that case why not wait for quick.db to support it directly rather than using experimental code?

@Sayrix Sayrix added the enhancement New feature or request label Jun 17, 2023
@zhiyan114
Copy link
Collaborator Author

It seems like all database driver formats are the same for the library. It's stable enough, they're probably waiting a bit longer to add other changes before releasing it.

@Sayrix
Copy link
Owner

Sayrix commented Jun 17, 2023

Can you try your code and say me if every functions of ticket-bot works ?

@Sayrix
Copy link
Owner

Sayrix commented Jun 17, 2023

Especially the emojis in the db

@zhiyan114
Copy link
Collaborator Author

Sure, though, I'll be later tonight since I won't be available near the dev PC for the day

@zhiyan114
Copy link
Collaborator Author

zhiyan114 commented Jun 18, 2023

The emoji won't be a problem, since Postgres already know how to handle that. The only issue I found is the default config table name that I initially set to, which conflicts with SQL's keyword. Other than that, it works like normal.

I'll def make another PR once quick.db push out the driver to clean stuff up, tho I do recommend you to plan to move away from squick.db because how inefficient it is at using database.

@zhiyan114 zhiyan114 changed the title Feat: PostgreSQL Support Feat: PostgreSQL Support & fixes Jun 18, 2023
@Sayrix Sayrix merged commit 8ddfe40 into Sayrix:main Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot crashes if webhook already exist for log channel that isn't accessible by the bot
2 participants