Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General fixes/improvements #200

Merged
merged 12 commits into from
Jul 19, 2023
Merged

General fixes/improvements #200

merged 12 commits into from
Jul 19, 2023

Conversation

zhiyan114
Copy link
Collaborator

@zhiyan114 zhiyan114 commented Jul 18, 2023 •
edited
Loading

  • Fix openTicket throws error if user deletes the message
  • Fix error being thrown due to incomplete translation file
  • Update dependencies
  • Check the existence of TOKEN environment variable
  • Check if Temp fix for engine bug #181 bug was caused by non-latest 18.x of node

@Sayrix
Copy link
Owner

Sayrix commented Jul 18, 2023

PR n°200 🎉

@zhiyan114
Copy link
Collaborator Author

PR n°200 🎉

Oh, I just noticed that lol

@zhiyan114 zhiyan114 self-assigned this Jul 18, 2023
@zhiyan114 zhiyan114 added this to the 5.2.0 milestone Jul 18, 2023
@zhiyan114 zhiyan114 marked this pull request as ready for review July 18, 2023 20:20
@zhiyan114 zhiyan114 requested a review from Sayrix as a code owner July 18, 2023 20:20
@Sayrix
Copy link
Owner

Sayrix commented Jul 18, 2023

No thats better a tab instead of 4 spaces

@zhiyan114 zhiyan114 marked this pull request as draft July 18, 2023 20:21
@zhiyan114 zhiyan114 marked this pull request as ready for review July 18, 2023 20:24
@zhiyan114 zhiyan114 marked this pull request as draft July 18, 2023 20:27
@zhiyan114
Copy link
Collaborator Author

No thats better a tab instead of 4 spaces

You want tab support? It seems better to be space for consistency. If you insist, I can revert it.

@Sayrix
Copy link
Owner

Sayrix commented Jul 18, 2023

On vscode i see it as 2 spaces

@Sayrix
Copy link
Owner

Sayrix commented Jul 18, 2023

i use tab on all my projects

@zhiyan114
Copy link
Collaborator Author

i use tab on all my projects

Oh, I moved away from tab because on some of my projects (especially involving python), mixing tab and space can cause all kinds of issue and space is just easier to deal with.

But ye, I'll revert it

@zhiyan114 zhiyan114 marked this pull request as ready for review July 18, 2023 21:05
@zhiyan114
Copy link
Collaborator Author

Alr, we should be good now.

@Sayrix Sayrix merged commit 0b8a3a3 into main Jul 19, 2023
@Sayrix Sayrix deleted the fixes branch July 19, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sayrix Sayrix Sayrix approved these changes

Assignees

@zhiyan114 zhiyan114

Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiyan114 @Sayrix