-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with Django #206
Conversation
Moved to ./django/ in the last push
The way I did it, I don't think it's the best, but since I didn't want to interfere with the bot's operation and I don't have much knowledge in javascript, I ended up doing this "workaround" lol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you sync the branch, i think there are conflicts with some changes that we made
I had changed some files by mistake, now they must be with the changes you made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also move the readme of django to DJANGO.md ?
Moved the django readme into the Django folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Hey, mind cleaning up
.gitignore
a bit?
I feel like not all of the files/directories that's listed will be generated when running the Django.
If I'm wrong, let me know. -
DJANGO.md
anddjango/README.md
seems to be a duplicate file -
django/trigger.py
seems to haveprint("aaaaa")
, not sure if you accidently left it there during development. - Both
django/tickets/tests.py
anddjango/tickets/views.py
are incomplete. if no test will be written, you can go head and delete it.
I was using the .gitignore python template, now it should be just the essentials
I removed the DJANGO.md
This was a print used for debugging that I ended up forgetting to delete
They are standard Django files, but as they won't be needed I removed them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright we good, I'll go head and merge it.
I made an integration with django that doesn't interfere with the code or with the tables already created in the database.
An auxiliary table is created to insert the new data, and it is possible to perform queries and CRUDs by Django Admin.