Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Deduplicate sections if modelattribute is present #393

Merged
merged 5 commits into from
May 20, 2020

Conversation

jmisur
Copy link
Contributor

@jmisur jmisur commented May 19, 2020

Fixes #380
Closes #386

Modelattribute was creating it's own section and therefore duplicating query params or request fields.
This PR makes modelattribute always merge with snippets above or even replace them if they are empty. It shows 2 tables, but it's better than 2 sections.

@jmisur jmisur changed the title 380 modelattribute fix Deduplicate sections if modelattribute is present May 19, 2020
@jmisur jmisur requested a review from fbenz May 20, 2020 08:12
@jmisur jmisur merged commit 753684c into master May 20, 2020
@jmisur jmisur deleted the 380-modelattribute-fix branch May 20, 2020 13:48
@fbenz fbenz mentioned this pull request Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect logic of @ModelAttribute support
2 participants