cpuid: limit search to current values #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved the APIs to make it clearer when leafs are not present. There are a few ways to identify when to stop scanning mentioned in the manual. For displaying facts, the code will now not only use a zero check in some cases, It will also pay attention to the advertized limits from the CPU.
cmouzaoui
reviewed
Jun 9, 2023
src/layout.rs
Outdated
Comment on lines
118
to
124
| if !is_empty_leaf(&cpuid) { | ||
| if let Some(cpuid) = cpuid.get_cpuid(leaf, 0) { | ||
| vec![cpuid] | ||
| } else { | ||
| vec![] |
There was a problem hiding this comment.
could this function that is an if let/else be more idiomatically expressed with a match?
match cpuid.get_cpuid(leaf, 0) {
Some(cpuid) => vec![cpuid],
None => vec![]
}it would probably be good to also disambiguate the names for the input and output cpuid's
cmouzaoui
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the APIs to make it clearer when leafs are not present. There are a few ways to identify when to stop scanning mentioned in the manual. For displaying facts, the code will now not only use a zero check in some cases, It will also pay attention to the advertized limits from the CPU.